Revise pull request template for issue linking#1394
Merged
Conversation
With many first-time contributors, we don't tell them that they should not use `Closes` when linking an issue that should remain open because their PR fixes only one or a few items in the original issue. This change supports that option.
stevepiercy
requested review from
SashankBhamidi and
niccokunzmann
as code owners
Coverage Report for CI Build 26330160306Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage remained the same at 97.777%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
SashankBhamidi
requested changes
May 23, 2026
Member
SashankBhamidi
left a comment
SashankBhamidi
left a comment
There was a problem hiding this comment.
Useful change. One thought:
Co-authored-by: Sashank <hello@sashank.wiki>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With many first-time contributors, we don't tell them that they should use
See, instead ofCloses, when linking an issue that should remain open because their PR fixes only one or a few items in the original issue. This change supports that option. Example #1369 (comment).